[Webkit-unassigned] [Bug 41614] RegExp constructor should throw a SyntaxError if invalid flags are specified

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 15:05:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41614


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62187|review?                     |review-
               Flag|                            |




--- Comment #4 from Oliver Hunt <oliver at apple.com>  2010-08-06 15:05:39 PST ---
(From update of attachment 62187)
provisional r- -- if you can convince me that the "error" constructor is necessary i'll r+ this, but currently it seems really hacky.

JavaScriptCore/runtime/RegExpCache.cpp:40
 +          return RegExp::createWithInvalidFlags();
Why return a new "magic" regexp rather than null?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list