[Webkit-unassigned] [Bug 43531] Web Inspector: Support appcache status change for Chrome

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43531





--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org>  2010-08-06 14:46:22 PST ---
The InspectorApplicationCache agent has the same lifetime as the InspectorFrontend.
It is considered an "Inspector Frontend Lifetime Agent". It only exists while there is
a frontend. For reference you can see this in InspectorController:

  - in InspectorController::connectFrontend, an InspectorFrontend is created and
     soon after an InspectorApplicationCache agent is created and passed that frontend.

  - in InspectorController::releaseFrontendLifetimeAgents it is cleared. Note this is
     called via disconnectFrontend.

That way, the InspectorApplicationAgent should only exist if there is a frontend, and
the frontend it has (m_frontend) should always exist.

I think you only need to check if the InspectorApplicationAgent exists or not,
for instance "page->inspectorController()->applicationCacheAgent()". You shouldn't
need to check for the frontend itself. Note, this is the approach that WebKit took:

>    if (Page *page = frame->page()) {
>        if (InspectorApplicationCacheAgent* applicationCacheAgent = page->inspectorController()->applicationCacheAgent()) {
>            ...
>        }
>    }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.