[Webkit-unassigned] [Bug 43503] Implement MathML deprecated style attributes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 6 14:36:54 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=43503
--- Comment #4 from Eric Seidel <eric at webkit.org> 2010-08-06 14:36:54 PST ---
(From update of attachment 63641)
WebCore/mathml/MathMLElement.cpp:54
+ || attrName == MathMLNames::colorAttr || attrName == MathMLNames::backgroundAttr
Seems this file really wants "using namespace MathMLNames;"
WebCore/mathml/MathMLElement.cpp:71
+ } else if (attr->name() == MathMLNames::mathcolorAttr)
These all do the same thing, no? I might have considered writing a helper function myself.
handleCSSMappedAttribute(attr, fontsizeAttr, CSSPropertyFontSize);
Then you just have a long line of those, instead of needing an if cascade. :) It's a nit, and not a big deal. Use your discretion.
Seems your png files aren't correctly marked as image/png
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list