[Webkit-unassigned] [Bug 43400] Add priority attribute to XMLHttpRequest
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 6 14:08:10 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=43400
Eric Seidel <eric at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #63617|review? |review-
Flag| |
--- Comment #18 from Eric Seidel <eric at webkit.org> 2010-08-06 14:08:09 PST ---
(From update of attachment 63617)
WebCore/xml/XMLHttpRequest.cpp:401
+ const char* const names[5] = { "critical", "high", "normal", "low", "lowest" };
Since we have this list...
WebCore/xml/XMLHttpRequest.cpp:412
+ if (s == "critical") {
why not just use it here. And use a for loop for the search? Sure, it's "slow", but this code is not hot. And will be less code (and less error prone).
Otherwise this looks OK.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list