[Webkit-unassigned] [Bug 39582] [Gtk] very slow page scrolling on big -webkit-box-shadow areas

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39582





--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com>  2010-08-06 11:10:12 PST ---
(From update of attachment 63741)
> diff --git a/WebCore/platform/graphics/cairo/FontCairo.cpp b/WebCore/platform/graphics/cairo/FontCairo.cpp
> index d14b371..e0d6c2c 100644
> --- a/WebCore/platform/graphics/cairo/FontCairo.cpp
> +++ b/WebCore/platform/graphics/cairo/FontCairo.cpp
> @@ -114,7 +114,7 @@ void Font::drawGlyphs(GraphicsContext* context, const SimpleFontData* font, cons
>              cairo_restore(shadowCr);
>          }
>          cairo_translate(cr, 0.0, -extents.height);
> -        context->createPlatformShadow(shadowBuffer.release(), shadowColor, shadowRect, radius);
> +        context->createPlatformShadow(shadowBuffer.release(), shadowColor, shadowRect, radius, true);

This is a great example of why boolean parameters are bad. I've no idea what 'true' means when reading this code.
An enum is better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.