[Webkit-unassigned] [Bug 43619] Bitmap.h has no default constructor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 10:45:37 PDT 2010


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
  Attachment #63718|review?                     |review-
               Flag|                            |

--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2010-08-06 10:45:37 PST ---
(From update of attachment 63718)
Nice catch.

 +      Bitmap(bool initializationNeeded = true);
WebKit is moving toward a policy of considering boolean arguments to functions to be a bad design pattern. I think we may eventually discourage or forbid them in our coding style guidelines. The problem with this kind of argument is that it's very hard to tell, at the callsite, exactly what "true" or "false" might mean.

I think you should just remove the boolean argument here.

If we do want to take advantage of an optimized "no initialization" bitmap in the future, let's add an extra constructor akin to the AdoptCFTag constructor for RetainPtr, or the VPtrStealingHackType constructor for JSString.

Otherwise, this patch is great!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list