[Webkit-unassigned] [Bug 42340] Web Inspector: extract debugger implementation into DebuggerAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42340


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




--- Comment #4 from Yury Semikhatsky <yurys at chromium.org>  2010-08-06 04:35:33 PST ---
(In reply to comment #2)
> (From update of attachment 63707 [details])
> WebCore/GNUmakefile.am:1600
>  +      WebCore/inspector/InspectorDebuggerAgent.h \
> Incorrect order.
> 
Fixed.

> WebCore/WebCore.xcodeproj/project.pbxproj: 
>  +              developmentRegion = English;
> is it necessary?
> 
No. Thanks.

> WebCore/inspector/InspectorDebuggerAgent.cpp:44
>  +  static String md5Base16(const String& string)
> Why do you need your own implementation of md5Base16?
> 
It was there before. Just forgot to remove it from InspectorController.cpp

> WebCore/inspector/InspectorDebuggerAgent.cpp:70
>  +      ScriptDebugServer::shared().addListener(agent.get(), inspectorController->inspectedPage());
> I think it would be better to move this code to ctor.
I'd rather keep it in the create method to make sure it's called only when the object is fully constructed. It would work either way I think since the constructor is private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.