[Webkit-unassigned] [Bug 42340] Web Inspector: extract debugger implementation into DebuggerAgent
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 6 03:07:45 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=42340
--- Comment #2 from Ilya Tikhonovsky <loislo at chromium.org> 2010-08-06 03:07:45 PST ---
(From update of attachment 63707)
WebCore/GNUmakefile.am:1600
+ WebCore/inspector/InspectorDebuggerAgent.h \
Incorrect order.
WebCore/WebCore.xcodeproj/project.pbxproj:
+ developmentRegion = English;
is it necessary?
WebCore/inspector/InspectorDebuggerAgent.cpp:44
+ static String md5Base16(const String& string)
Why do you need your own implementation of md5Base16?
WebCore/inspector/InspectorDebuggerAgent.cpp:70
+ ScriptDebugServer::shared().addListener(agent.get(), inspectorController->inspectedPage());
I think it would be better to move this code to ctor.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list