[Webkit-unassigned] [Bug 43603] Add form client for injected bundle code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 20:10:13 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43603


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-08-05 20:10:13 PST ---
Attachment 63682 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:131:  Extra space between int and version  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:133:  Extra space between WKBundlePageTextFieldDidBeginEditingCallback and textFieldDidBeginEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:134:  Extra space between WKBundlePageTextFieldDidEndEditingCallback and textFieldDidEndEditing  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:135:  Extra space between WKBundlePageTextDidChangeInTextFieldCallback and textDidChangeInTextField  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:136:  Extra space between WKBundlePageTextDidChangeInTextAreaCallback and textDidChangeInTextArea  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list