[Webkit-unassigned] [Bug 43531] Web Inspector: Support appcache status change for Chrome

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43531


Kavita Kanetkar <kkanetkar at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63647|                            |review?
               Flag|                            |




--- Comment #1 from Kavita Kanetkar <kkanetkar at chromium.org>  2010-08-05 15:33:27 PST ---
Created an attachment (id=63647)
 --> (https://bugs.webkit.org/attachment.cgi?id=63647)
proposed fix

Here, the appcache status update piggybacks off ApplicationCacheHost::notifyDOMApplicationCache()
and pushes the status to inspector frontend via an *expensive* call status().

So is the check for:
page->inspectorController()->inspectorFrontend()

sufficient to guarantee that inspector is launched and only for that page? 
I did look through the code and looks like disconnectFrontend() is called if there's no frontend open.
Again, if frontend is connected for other pages,
page->inspectorController()->inspectorFrontend() 
will still be NULL if this particular appcache host's page does not have inspector open. Am I correct?

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.