[Webkit-unassigned] [Bug 41842] Add feature detection support for NRWT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 13:50:53 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41842





--- Comment #7 from Dirk Pranke <dpranke at chromium.org>  2010-08-05 13:50:52 PST ---
(From update of attachment 61033)
Maybe I'm missing something, but I still don't think you need the copy on line 241 of webkit.py. There's no case where you would want to delete the directories from skipped_directories and then add them back in, and so there's no point in looking at the keys in directories_for_symbol over and over again if you've deleted them. There's no correctness issue, but it's unnecessary (and slower).

Otherwise, LGTM (but I'm not a reviewer).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list