[Webkit-unassigned] [Bug 43524] Add DOM Node wrapper class for injected bundle

Thu Aug 5 11:57:25 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43524

Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63610|review?                     |review+
               Flag|                            |

--- Comment #4 from Anders Carlsson <andersca at apple.com>  2010-08-05 11:57:25 PST ---
(From update of attachment 63610)
> Index: WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
> ===================================================================
> --- WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp	(revision 0)
> +++ WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp	(revision 0)

> +
> +static DOMHandleCache& domHandleCache()
> +{
> +    static DOMHandleCache cache;

This should use DEFINE_STATIC_LOCAL to avoid an exit time destructor.

> +PassRefPtr<InjectedBundleNodeHandle> InjectedBundleNodeHandle::get(Node* node)

I prefer the name getOrCreate here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.