[Webkit-unassigned] [Bug 43516] REGRESSION: Huge number of memory leaks after enabling MathML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43516





--- Comment #8 from Beth Dakin <bdakin at apple.com>  2010-08-05 11:36:55 PST ---
Index: mathml/RenderMathMLOperator.cpp
===================================================================
--- mathml/RenderMathMLOperator.cpp    (revision 64705)
+++ mathml/RenderMathMLOperator.cpp    (working copy)
@@ -118,10 +118,18 @@
 void RenderMathMLOperator::updateFromElement()
 {
     // clear our children
     while (firstChild()) {
        RenderObject* obj = firstChild();
        removeChild(obj);
+       obj->destroy();
     }
+
+    node()->setRenderer(this);

This fixes the leaks without any crashes. But I would really like the understand the design better before committing it. Are we totally sure we want all of these renderers to share a node?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.