[Webkit-unassigned] [Bug 42970] [IndexedDB] IndexedDB is missing the Transaction interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42970





--- Comment #5 from Andrei Popescu <andreip at google.com>  2010-08-05 09:37:06 PST ---
Thanks for the quick review Jeremy!

(In reply to comment #3)
> (From update of attachment 63579 [details])
> WebCore/dom/EventNames.h:45
>  +      macro(complete) \
> what is this stuff?
>

IDBTransaction adds two new events: oncomplete and ontimeout.

> WebCore/storage/IDBDatabase.idl:42
>  +          [CallWith=ScriptExecutionContext] IDBTransaction transaction (in [Optional] DOMStringList storeNames, in [Optional] unsigned short mode, in [Optional] unsigned long timeout);
> not sure using domStringList as an input like this will work out of the box....I don't think anyone's tried
> 


Yeah, I'll check and see. If it's not working, I'll fix it in a separate patch.


> WebCore/storage/IDBTask.h:2
>  +   * Copyright (C) 2010 Google Inc. All rights reserved.
> use ScriptExecutionContext::Task and the CrossThreadTask stuff instead of rolling your own
> 

Used.

> WebCore/storage/IDBTransaction.cpp:15
>  +      : ActiveDOMObject(context, this), m_transaction(backend), m_database(db)
> put each on its own line
>

Put.

> WebCore/storage/IDBTransaction.cpp:25
>  +      return IDBTransaction::READ_ONLY;
> Hook these up to the backend interface...I actually don't think you need any FIXMEs in this file since all the work happens in the backend.
>

Hooked.

> WebCore/storage/IDBTransaction.h:85
>  +      RefPtr<IDBTransactionBackendInterface> m_transaction;
> m_backend maybe?

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.