[Webkit-unassigned] [Bug 38050] Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38050





--- Comment #19 from mitz at webkit.org  2010-08-05 09:06:42 PST ---
(In reply to comment #14)
> I was able to hook up the debugger today to look a little closer at this.
> 
> It seems that the test page attached to the bug uses a RenderButton, which is a FlexibleBox. It inherits the visibility:collapse from it's containing <div> which I think, is not a FlexibleBox.
> 
> When we are calculating the style diff for the RenderButton, its display property is set to INLINE_BLOCK. So it doesn't seem to follow that RenderObject::isFlexibleBox() corresponds to a display of BOX. Is that correct?

You’re right. RenderButton inherits from RenderFlexibleBox, and thus returns true from isFlexibleBox() regardless of its display type.

> I'm now starting to wonder whether this should be restricted to flexible boxes as Mitz suggested in comment 7. Should we be doing this for all RenderObjects?

It would still be good to do this only for flexible box, but RenderStyle alone can’t tell you whether you’re a flexible box because of the above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.