[Webkit-unassigned] [Bug 43117] Chromium regression when viewing a plugin document with plugins disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 07:23:54 PDT 2010


Bernhard Bauer <bauerb at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #63588|                            |review?, commit-queue?
               Flag|                            |

--- Comment #3 from Bernhard Bauer <bauerb at chromium.org>  2010-08-05 07:23:53 PST ---
Created an attachment (id=63588)
 --> (https://bugs.webkit.org/attachment.cgi?id=63588)
Remove assertion from PluginDocumentParser::appendBytes

I looked into it a bit, and I think that simply removing the failing ASSERT would be the right thing to do. appendBytes is called from FrameLoader::addData and from DocumentWriter::endIfNotLoadingMainResource (with a NULL string in the latter case), so the assumption that appendBytes is not called more than once is definitely not true. On the next line is a check that returns if m_embedElement already exists, so we also don't end up creating the document more than once.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list