[Webkit-unassigned] [Bug 42970] [IndexedDB] IndexedDB is missing the Transaction interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42970


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63579|review?                     |review-
               Flag|                            |




--- Comment #3 from Jeremy Orlow <jorlow at chromium.org>  2010-08-05 06:56:28 PST ---
(From update of attachment 63579)
WebCore/dom/EventNames.h:45
 +      macro(complete) \
what is this stuff?

WebCore/storage/IDBDatabase.idl:42
 +          [CallWith=ScriptExecutionContext] IDBTransaction transaction (in [Optional] DOMStringList storeNames, in [Optional] unsigned short mode, in [Optional] unsigned long timeout);
not sure using domStringList as an input like this will work out of the box....I don't think anyone's tried

WebCore/storage/IDBTask.h:2
 +   * Copyright (C) 2010 Google Inc. All rights reserved.
use ScriptExecutionContext::Task and the CrossThreadTask stuff instead of rolling your own

WebCore/storage/IDBTransaction.cpp:15
 +      : ActiveDOMObject(context, this), m_transaction(backend), m_database(db)
put each on its own line

WebCore/storage/IDBTransaction.cpp:25
 +      return IDBTransaction::READ_ONLY;
Hook these up to the backend interface...I actually don't think you need any FIXMEs in this file since all the work happens in the backend.

WebCore/storage/IDBTransaction.h:85
 +      RefPtr<IDBTransactionBackendInterface> m_transaction;
m_backend maybe?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.