[Webkit-unassigned] [Bug 41888] Initial bindings and plumbing for IDBCursor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41888


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63462|review?                     |review+
               Flag|                            |




--- Comment #29 from Jeremy Orlow <jorlow at chromium.org>  2010-08-05 06:19:09 PST ---
(From update of attachment 63462)
WebCore/WebCore.vcproj/WebCore.vcproj:50244
 +          RelativePath="..\storage\IDBCursor.cpp"
intending is wrong

WebCore/storage/IDBCursor.h:48
 +      // Keep in sync with what's in the .idl file.
don't need this comment anymore, right?

WebCore/storage/IDBCursor.idl:31
 +          // Keep in sync with what's in the .h file.
ditto?

WebCore/storage/IDBObjectStoreImpl.cpp:142
 +      callbacks->onSuccess(cursor.release());
Please double check this is what the spec specifies for the case that the key doesn't exist.

WebCore/storage/IDBObjectStoreRequest.h:69
 +      PassRefPtr<IDBRequest> openCursor(ScriptExecutionContext*, PassRefPtr<IDBKeyRange> range = 0, unsigned short direction = IDBCursor::NEXT);
do you have to define the variable name in order to do a default param?  if not, delete "range"

WebKit/chromium/public/WebIDBKeyRange.h:55
 +      WebIDBKeyRange(const WTF::PassRefPtr<WebCore::IDBKeyRange>&);
if you do one, do all three

WebKit/chromium/src/WebIDBCursorImpl.cpp:71
 +  
extra new line


r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.