[Webkit-unassigned] [Bug 38050] Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38050





--- Comment #17 from Ben Murdoch <benm at google.com>  2010-08-05 04:46:31 PST ---
(In reply to comment #16)
> (From update of attachment 63455 [details])
> > +    if ((visibility() == COLLAPSE && other->visibility() != COLLAPSE)
> > +        || (visibility() != COLLAPSE && other->visibility() == COLLAPSE))
> > +        return StyleDifferenceLayout;
> 
> I think it is more readable like this:
> 
>     if ((visibility() == COLLAPSE) != (other->visibility() == COLLAPSE))
>         return StyleDifferenceLayout;

SGTM, will send a replacement patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.