[Webkit-unassigned] [Bug 38701] [chromium] don't call fontconfig twice in complex text path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38701





--- Comment #26 from MORITA Hajime <morrita at google.com>  2010-08-04 22:51:56 PST ---
(From update of attachment 63553)
Hi, thank you for your patch! I'll try to take a look:

> --- a/WebCore/platform/graphics/FontCache.h
> +++ b/WebCore/platform/graphics/FontCache.h
> @@ -102,6 +102,7 @@ private:
>      // These methods are implemented by each platform.
>      SimpleFontData* getSimilarFontPlatformData(const Font&);
>      FontPlatformData* createFontPlatformData(const FontDescription&, const AtomicString& family);
> +    void invalidatePlatform();
Who call this? If chromium side, it's OK, if it will be called inside webkit, such code might be bette to stay in same patch.

> +typedef HashMap<String, SkTypeface*> TypefaceCache;
> +
> +static TypefaceCache *gTypefaceChache = 0;
> +
Because FontCache instance itself global, 
It can be a class member field instead of static variable.
Dynamically allocated static variable typically make valgrind unhappy, 
we should avoid them if possible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.