[Webkit-unassigned] [Bug 43534] New: Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 19:50:18 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43534

           Summary: Remove superfluous non-negative checks in
                    HitTestResult:padding{Width|Height}
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tonikitoo at webkit.org
                CC: hyatt at apple.com, steveblock at google.com


As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 , the non-negative checks present in both paddingWidth and paddingHeight methods of HitTestResults class are superflous, after we changed the rect based hit testing logic of invalid padding  from IntSize(-1, -1) to IntSize(0, 0).

I missed updating these two method while addressing last hyatt's reviews.

Patch coming.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list