[Webkit-unassigned] [Bug 42827] Use the js-execute-active(entered) Frame to check the user gesture of page instead of checking the top frame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 18:18:43 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=42827


Johnny Ding <jnd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63525|                            |commit-queue?
               Flag|                            |




--- Comment #29 from Johnny Ding <jnd at chromium.org>  2010-08-04 18:18:42 PST ---
Created an attachment (id=63525)
 --> (https://bugs.webkit.org/attachment.cgi?id=63525)
patch v3 to remove strange character in previous patch

(In reply to comment #28)
> (From update of attachment 63451 [details])
> WebCore/WebCore.order:7344
>  +  __ZN7WebCore16ScriptController21processingUserGestureEv´┐Ż
> There appears to be a strange character here.
Done

> WebCore/bindings/js/JSDOMBinding.cpp:682
>  +  bool processingUserGesture()
> Maybe remove all callers of this method?  They just need to call the ScriptController version.
The processingUserGesture in JSDOMBinding.cpp is used in derived source code and all derived source files do not include ScriptController.h, so processingUserGesture looks like a wrapper function to call the implementation function without introducing more head files. We may need to keep it.


The new patch is same as the previous one yury approved except I removed the strange character in previous patch. So I didn't add the review mark.
If we are all satisfied with this one, would you please help on landing? Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list