[Webkit-unassigned] [Bug 43515] New: Fix small design issues with PageAllocation, split out PageReservation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 15:28:32 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43515

           Summary: Fix small design issues with PageAllocation, split out
                    PageReservation.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: barraclough at apple.com


The PageAllocation class has a number of issues.

* Changes in bug #43269 accidentally switched SYMBIAN over to use malloc/free to allocate blocks of memory for the GC heap, instead of allocating RChunks.  Revert this change in behaviour.
* In order for PageAllocation to work correctly on WinCE we should be decommitting memory before deallocating.  In order to simplify understanding the expected state at deallocate, split behaviour out into PageAllocation and PageReservation classes.  Require that all memory be decommitted before calling deallocate on a PageReservation, add asserts to enforce this.
* add many missing asserts.
* inline more functions.
* remove ability to create sub-PageAllocations from an existing PageAllocations object – this presented an interface that would allow sub regions to be deallocated, which would not have provided expected behaviour.
* remove writable/executable arguments to commit, this value can be cached at the point the memory is reserved.
* remove writable/executable arguments to allocateAligned, protection other than RW is not supported.
* add missing checks for overflow & failed allocation to mmap path through allocateAligned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list