[Webkit-unassigned] [Bug 43448] [Qt] [QtTestBrowser] Clean up static and global menu state controls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 09:13:35 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43448


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |tonikitoo at webkit.org
                   |kit.org                     |
  Attachment #63457|                            |review?
               Flag|                            |




--- Comment #1 from Antonio Gomes <tonikitoo at webkit.org>  2010-08-04 09:13:35 PST ---
Created an attachment (id=63457)
 --> (https://bugs.webkit.org/attachment.cgi?id=63457)
patch v1

After LauncherWindow class was refactored out of from main.cpp, all global variables that were anging in main.cpp became temporarily public static class members of newly added LauncherWindow class. This design was not properly handling the initial purpose of the global variables: newly created launcher windows should inherit the settings of the originating one.

In order to properly fix the problem, this patch introduces a LauncherData class, as a POD. It comprises all data needed to handling the goal described above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list