[Webkit-unassigned] [Bug 42244] SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42244


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63445|review?                     |review+
               Flag|                            |




--- Comment #31 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-04 06:49:15 PST ---
(From update of attachment 63445)
r=me, with one comment:
WebCore/svg/SVGFilterElement.h:65
 +              if (parent->hasTagName(SVGNames::filterTag)) {

I'd prefer another way to write this function:

static void invalidateFilter(SVGElement* element)
{
    ASSERT(element);
    if (!element->inDocument())
        return;
    Node* parent = element->parentNode();
    while (parent && !parent->hasTagName(SVGNames::filterTag))
        parent = parent->parentNode();

    if (!parent)
        return;

    ASSERT(parent->hasTagName(SVGNames::filterTag));
    if (RenderObject* renderer = parent->renderer())
        renderer->setNeedsLayout(true);
}

Please modify to use more early returns before landing :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.