[Webkit-unassigned] [Bug 38169] check-webkit-style returns non-zero when patch is entirely minus lines

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 02:32:35 PDT 2010


--- Comment #6 from Kenichi Ishibashi <bashi at google.com>  2010-08-04 02:32:34 PST ---
(In reply to comment #5)

Thank you for your quick review.

> (From update of attachment 63427 [details])
> We need to update unittest for them.

I'm sorry for missing tests. I'll add unittests for them.

> WebKitTools/Scripts/webkitpy/style/filereader.py:61
>  +          self.processed_file_count = 0
> Please update the docstring above.

I've noticed that the variable also counts skipped files so that I'll revert the change.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list