[Webkit-unassigned] [Bug 43395] [GTK/EFL] rendering was broken in naver.com

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43395





--- Comment #5 from Ryuan Choi <ryuan.choi at samsung.com>  2010-08-03 19:59:34 PST ---
(In reply to comment #4)
> (In reply to comment #2)
> > Created an attachment (id=63293)
 --> (https://bugs.webkit.org/attachment.cgi?id=63293) [details] [details]
> > Patch
> 
> I'm not a reviewer, but I have some comments:
> 
> @@ -605,6 +606,8 @@ void RenderThemeEfl::themeChanged()
>      applyPartDescriptions();
>  }
> 
> +float RenderThemeEfl::defaultFontSize = 16.0f;
> +
> 
> I know this is the defaultFontSize, but maybe we should get this from settings, as Chromium does. For this you would need to create a RenderThemeEfl::setDefaultFontSize(), and call it from ewk_view_setting_font_default_size_set and _ewk_view_priv_new (setting to 16 on the last one).
> 
I agree, I'll prepare

> But I'm not sure if this is the best approach though.
> 
> +        // Why 2 points smaller? Because that's what Gecko does. Note that we
> +        // are assuming a 96dpi screen, which is the default that we use on
> +        // Windows.
> +        static const float pointsPerInch = 72.0f;
> +        static const float pixelsPerInch = 96.0f;
> +        fontSize -= (2.0f / pointsPerInch) * pixelsPerInch;
> +        break;
> +    }
> 
> Well, at least you should remove the "Windows" part of this comment, no? :P
> And I don't know exactly what pointsPerInch is for, but it's possible to get the dpi from Ecore_X. Maybe this helps...

yes, I just copied :)
I think we have more discussion about dpi, but we can remove this now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.