[Webkit-unassigned] [Bug 42939] WebEditorClient::didBeginEditing is never called in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42939


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
         AssignedTo|ap at webkit.org               |webkit-unassigned at lists.web
                   |                            |kit.org
                 CC|                            |sam at webkit.org




--- Comment #3 from Sam Weinig <sam at webkit.org>  2010-08-03 13:26:12 PST ---
(In reply to comment #1)
> This is caused by an incomplete implementation of becomeFirstResponder. WebKit1 version does much more work - specifically, this problem is caused by a missing FocusController::setFocusedFrame() call.

>From the looking at the windows code, it looks like something like

void WebPage::setFocused(bool isFocused)
{
    FocusController* focusController = m_page->focusController();
    focusController->setFocused(isFocused);

    if (isFocused) {
        if (!focusController->focusedFrame())
            focusController->setFocusedFrame(m_page->mainFrame());
    }
}

should do most of the necessary work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.