[Webkit-unassigned] [Bug 43344] Web Inspector: Extensions API tests fail on Qt & GTK

Tue Aug 3 12:54:29 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43344

Andrey Kosyakov <caseq at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63367|                            |review?
               Flag|                            |

--- Comment #2 from Andrey Kosyakov <caseq at chromium.org>  2010-08-03 12:54:29 PST ---
Created an attachment (id=63367)
 --> (https://bugs.webkit.org/attachment.cgi?id=63367)
patch

The tests broke because platform-specific DumpRenderTree code for Qt & GTK happened to have developerExtrasEnabled set to false. This was enabled per-page by the test running code, but not for the inspector page itself.
Performing API injection conditionally on WebInspector::enabled() happened to be bad idea when enabled() may vary per-page. The only chance to have something in m_scriptsToEvaluateOnLoad is via WebInspector, so injecting these scripts when inspector is not enabled() for inspector's page should be ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.