[Webkit-unassigned] [Bug 43372] [wx] Crash during HitTest call

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 11:46:47 PDT 2010


--- Comment #4 from Kevin Ollivier <kevino at theolliviers.com>  2010-08-03 11:46:47 PST ---
(In reply to comment #3)
> Thanks! Landed in r64568. 
> A couple remarks for future patches. One, there is a 'patch' checkbox which lets the system know the attachment is a patch, and setting ? on the review queue marks it as needing review. (It also actually initiates try-bots which attempt to compile the patch.)
> Also, typically patches are supposed to contain a ChangeLog entry, which can be auto-generated using WebKitTools/Scripts/prepare-ChangeLog. Typically patches missing a ChangeLog entry are supposed to be given a bad review and sent back for reworking, but as this was fixing a crash, I felt it was best to be expedient and land this ASAP, adding the ChangeLog entry myself.

Err, bad review is a poor choice of words. :) I mean an r-, which means it isn't ready to land.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list