[Webkit-unassigned] [Bug 43429] [GTK] Does not paint the node highlight used by the inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43429


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63341|review?                     |review+
               Flag|                            |




--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2010-08-03 10:02:38 PST ---
(From update of attachment 63341)
>-void InspectorClient::highlight(Node* node)
>+void InspectorClient::highlight(Node*)
> {
>-    notImplemented();
>+    hideHighlight();
> }
> 
> void InspectorClient::hideHighlight()
> {
>-    notImplemented();
>+    // FIXME: we should be able to only invalidate the actual rects of
>+    // the new and old nodes. We need to track the nodes, and take the
>+    // actual highlight size into account when calculating the damage
>+    // rect.
>+    gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView));
> }

There's some huge epic fail in naming going on here ;)


>+        ctx.save();
>+        ctx.clip(static_cast<IntRect>(event->area));
>+        frame->page()->inspectorController()->drawNodeHighlight(ctx);
>+        ctx.restore();
>     }

As discussed on jabber, the save/restore stuff is probably not needed.

> 
>     return FALSE;
>-- 
>1.7.1
>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.