[Webkit-unassigned] [Bug 43276] Implements IDBKeyPath extractor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43276





--- Comment #9 from Jeremy Orlow <jorlow at chromium.org>  2010-08-03 05:09:14 PST ---
(From update of attachment 63313)
WebKit/chromium/tests/IDBKeyPathTest.cpp:32
 +  #if ENABLE(INDEXED_DATABASE)
move this up...or....actually maybe just get rid of?

WebKit/chromium/tests/IDBBindingUtilitiesTest.cpp:35
 +  #if ENABLE(INDEXED_DATABASE)
ditto

WebCore/storage/IndexedDatabaseRequest.idl:31
 +          [CallWith=ScriptExecutionContext] IDBRequest open(in DOMString name, in DOMString description);
Umm....what's this file doing here?

WebCore/storage/IndexedDatabaseRequest.h:48
 +  class IndexedDatabaseRequest : public RefCounted<IndexedDatabaseRequest> {
ditto

WebCore/storage/IndexedDatabaseRequest.cpp:55
 +  PassRefPtr<IDBRequest> IndexedDatabaseRequest::open(ScriptExecutionContext* context, const String& name, const String& description)
and again

WebCore/storage/IDBKeyPath.cpp:33
 +  #if ENABLE(INDEXED_DATABASE)
move up

WebCore/bindings/v8/IDBBindingUtilities.h:40
 +  PassRefPtr<IDBKey> valueForKeyPath(const String& wireData, const String& keyPathString);
Should this just take a SerializedScriptValue?

WebCore/bindings/v8/IDBBindingUtilities.cpp:54
 +      RefPtr<IDBKeyPath> keyPath = IDBKeyPath::create(keyPathString);
Check whether it's valid before going on.

Of course....shouldn't we just compile once.  I.e. pass in an IDBKeyPath to the function?

WebCore/bindings/v8/IDBBindingUtilities.cpp:61
 +              v8::Local<v8::Object> object = v8Value->ToObject();
Is this the best way to do this?

WebCore/bindings/v8/IDBBindingUtilities.cpp:66
 +              if (!v8Value->IsObject())
Can this stuff be factored out?



You should probably do all the build files and JSC support in this patch as well.

Still haven't done a detailed review of the actual parser.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.