[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898





--- Comment #54 from Mario Sanchez Prada <msanchez at igalia.com>  2010-08-03 03:04:42 PST ---
(In reply to comment #53)
> Mario, I would greatly appreciate if you could merge all the patches into 
> one.

I did it in separate patches because I thought it would be better for reviewing them. But I do not have any problem squashing them all into just one patch, I'll upload it as soon as I have it done and tested.

> I have a hard time understanding now which ones are in an which ones are out.

Basically, none of them are in now.

Patches (2) and (3) are currently review+ but not committed yet since they're dependant on patch (1), the one I was actually asking you for reviewing it :-)

> I'll be happy to review the editing specific part.

Great, thanks!

> I would like to be able to assess the impact on these changes for platforms 
> other than Gtk.

Currently I just can test this for the GTK platform. I'll try to somehow measure the performance to see whether there's some regression on that regard.

> As far as testing, use as reference the folder accessibility under 
> LayoutTests. You can find a lot of examples of tests for accessibility 
> related stuff. Take a look at the source code of dumpRenderTree to get more 
> details on the accessibilityController object and its capabilities.

Been there, done that :-), actually my question was more about what kind of test I could do to check whether these changes are correct or not, I mean... whether you could have an idea of what kind of assertions, situations and so forth I should test to make sure the change is correct.

So far I've checked no regressions happened neither in the current Layout tests nor in the unit tests, not sure whether that's enough, though.

Thanks for the feedback, I'll be back soon with the squashed patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.