[Webkit-unassigned] [Bug 35351] [GTK] DRT implement execCommand()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35351





--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2010-08-02 19:37:28 PST ---
(In reply to comment #7)
> (From update of attachment 63136 [details])
> >-bool LayoutTestController::isCommandEnabled(JSStringRef /*name*/)
> >+void LayoutTestController::setCacheModel(int)
> > {
> >     // FIXME: implement
> >-    return false;
> > }
> So in the ChangeLog you say you are only moving this, but you are also adding a return false. Is it needed or just added by mistake?

I think that's just a case of a slightly confusing diff. In this case, I removed the "return false" in this location and replaced it with the result of webkit_web_view_is_command_enabled above.

> >+
> Not needed?

Fixed!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.