[Webkit-unassigned] [Bug 42922] [chromium] WebViewClient should have an elementClicked() method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 16:07:35 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=42922





--- Comment #9 from Jay Civelli <jcivelli at chromium.org>  2010-08-02 16:07:35 PST ---
@fishd
Sorry my patch was wrong. I meant to have clickedElement be the clickedNode, not the focused element.

As you suggest, I could probably use an event listener from the Chromium side instead.
I could add an event listener for mousedown on the document in render_view.cc
I have to use mousedown instead of click because by the time I get notified of the click, the mousedown event already focused the field and I have no way of knowing if the input field was focused before it was clicked (I need to know that so we can have the autofill behavior where clicking a focused input shows the autofill popup).

I am not sure there is a reentrency problem in that case, but I can see how some other listeners might change the focus. In that case we probably would not want to notify for autofill purposes. I could post a task so to process the notification and check which element is focused after all listeners have returned (once the stack has unwinded).

Do you think it makes sense?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list