[Webkit-unassigned] [Bug 35351] [GTK] DRT implement execCommand()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35351


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63136|review?                     |review+
               Flag|                            |




--- Comment #7 from Xan Lopez <xan.lopez at gmail.com>  2010-08-02 14:12:55 PST ---
(From update of attachment 63136)
>-bool LayoutTestController::isCommandEnabled(JSStringRef /*name*/)
>+void LayoutTestController::setCacheModel(int)
> {
>     // FIXME: implement
>-    return false;
> }

So in the ChangeLog you say you are only moving this, but you are also adding a return false. Is it needed or just added by mistake?

> 
>+

Not needed?

> void LayoutTestController::setPersistentUserStyleSheetLocation(JSStringRef jsURL)
> {
>     // FIXME: implement

Looks good other than that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.