[Webkit-unassigned] [Bug 43354] New: Potential Null Crasher in ReplaceSelectionCommand

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 08:46:58 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43354

           Summary: Potential Null Crasher in ReplaceSelectionCommand
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: rniwa at webkit.org


http://trac.webkit.org/browser/trunk/WebCore/editing/ReplaceSelectionCommand.cpp#L935

935        if ((isListElement(refNode.get()) || (isStyleSpan(refNode.get()) && isListElement(refNode->firstChild())))
936            && blockStart->renderer()->isListItem())
937            refNode = insertAsListItems(refNode, blockStart, insertionPos);

I suspect that unguarded renderer()-> call could crash.  Nodes don't have to have renderers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list