[Webkit-unassigned] [Bug 43353] New: generate-bindings.pl should generate warning free code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 08:39:58 PDT 2010


           Summary: generate-bindings.pl should generate warning free code
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
            Blocks: 43191

WebCore/generated/JSBlobBuilder.cpp is generated by WebCore/bindings/scripts/generate-bindings.pl,
and gcc-4.3.2 reports this warning:
generated/JSBlobBuilder.cpp: In function ‘JSC::EncodedJSValue WebCore::jsBlobBuilderPrototypeFunctionAppend(JSC::ExecState*)’:
generated/JSBlobBuilder.cpp:255: warning: suggest parentheses around && within ||

if ((exec->argumentCount() == 1 && (exec->argument(0).isNull() || exec->argument(0).isObject() && asObject(exec->argument(0))->inherits(&JSBlob::s_info))))

generate-bindings.pl should generate this line:
if ((exec->argumentCount() == 1 && (exec->argument(0).isNull() || (exec->argument(0).isObject() && asObject(exec->argument(0))->inherits(&JSBlob::s_info)))))

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list