[Webkit-unassigned] [Bug 42827] Use the js-execute-active(entered) Frame to check the user gesture of page instead of checking the top frame

Mon Aug 2 05:06:37 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42827

--- Comment #20 from Johnny Ding <jnd at chromium.org>  2010-08-02 05:06:37 PST ---
(In reply to comment #18)

> The problem was in the assumption that any entered context has an internal field pointing to V8DOMWindow which is wrong in case of devtools utility context. In the scenario which I was trying to fix we had an inspector JS code calling inspector bindings from the utility context and then native inspector code invoking some method that required isProcessingUserGesture check. The check would end up with an assertion failure in V8Proxy::retrieveWindow(because there is not pointer to V8DOMWindow from the utility context). Making ScriptController::processingUserGesture not depend on the entered context looked like a good solution and I continue to think that it shouldn't depend on the entered context. ScriptController has access to the Frame and to its owning Page which should be enough to figure out whether there is an active user gesture. 

@Yury, Thanks for your detailed explanation, Yury!
Yes, ScriptController has access to its owning Frame to check whether there is an active user gesture. But the user gesture can be initiated from another frame, I agree with Adam that in most situation clients just want to know if we're processing a user gesture, so a unified interface to get user gesture info looks more convenient.

@Adam, any comments for my patch V2 except Darin's comment? I'd like to get more comments before sending the new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.