[Webkit-unassigned] [Bug 42976] Implement IDBKeyPath parser.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 04:03:06 PDT 2010


--- Comment #14 from Marcus Bulach <bulach at chromium.org>  2010-08-02 04:03:06 PST ---
(In reply to comment #12)
> > void IDBKeyPath::parse()
> > (...)
> >  case Array : {
> > (...)
> > m_lexer.next();
>  > token = m_lexer.currentToken();
> Same question here as in 42976: You are only checking for dot or left bracket. But what if tokEnd follows? Seems like you're returning ParserErrorAfterArray in that case?

yes, good point.
fixed in the latest patch, and also tidy up with the following rule:
1. added an "End" state.
2. on any given state, there's a set of "state changes" depending on the condition.
3. if there's an error, it returns.

I also added a couple of test for this case as well.

hopefully this simplifies the state transitions, but I'd surely appreciate more eyes looking into it. another look, please?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list