[Webkit-unassigned] [Bug 40002] Need Geolocation LayoutTest to test case where permission has neither been granted nor denied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40002


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62699|review?                     |review+
               Flag|                            |




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2010-08-02 02:46:55 PST ---
(From update of attachment 62699)
+    [[[mainFrame webView] UIDelegate] didSetGeolocationPermission];

I'd still prefer this to be called didSetMockGeolocationPermission (same for a few other names, of course) . It's hard to understand the various permissions here, so being specific helps.

+    HashSet<id<WebGeolocationPolicyListener> > m_pendingGeolocationPermissionListeners;

This code is fine in the short run, but HashSet isn't a great data structure to keep Objective-C objects in. Specifically, we'll get problems if we try to run DumpRenderTree in garbage collected mode.  NSMutableSet is the easiest way to make the code more clean.

r=me, but please consider addressing these comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.