[Webkit-unassigned] [Bug 38413] Add callback based API to get the textual representation of the RenderTree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38413


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-30 17:17:17 PST ---
Attachment 54837 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
exit_code: 1
WebKit2/UIProcess/API/C/WKPage.cpp:132:  WKPageRunJavaScriptInMainFrame_f is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebKit2/UIProcess/API/C/WKPage.cpp:157: 
WKPageRenderTreeExternalRepresentation_f is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/RenderTreeExternalRepresentationCallback.h:34:  Code inside a
namespace should not be indented.  [whitespace/indent] [4]
WebKit2/UIProcess/RenderTreeExternalRepresentationCallback.cpp:26:  Found
header this file implements before WebCore config.h. Should be: config.h,
primary header, blank line, and then alphabetically sorted. 
[build/include_order] [4]
WebKit2/UIProcess/ScriptReturnValueCallback.h:34:  Code inside a namespace
should not be indented.  [whitespace/indent] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.