[Webkit-unassigned] [Bug 38344] Remove custom bindings for HTMLInputElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38344


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54732|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-04-30 11:52:30 PST ---
(From update of attachment 54732)
I think HTMLInputElement.h needs a comment as to why we're adding these.  But I
think this looks OK.

Should we be be making selectionStart, etc. virtual and overriding them in
HTMLIntputElement as private members?  Should we change the baseclass to take
an ExceptionCode and only throw it for HTMLInputElement?

I think this is OK as is, but I worry that folks could easily use the wrong
one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.