[Webkit-unassigned] [Bug 38393] New: specifying both --git-commit and --squash should throw an error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38393

           Summary: specifying both --git-commit and --squash should throw
                    an error
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ojan at chromium.org
                CC: eric at webkit.org, jamesr at chromium.org,
                    cjerdonek at webkit.org


--git-commit will squash all the commits in the commit range into one. --squash
grabs the full diff from trunk. The two are currently mutually exclusive.

You could also imagine a world in which git-commit was more like dcommit
(treats each commit in the range as a separate patch). If we did that, then it
would make sense to allow both. In other words, ideally, --git-commit would
only treat the commit range as a single patch if you also specified --squash.

But, since the code currently squashes, I think we should throw an error for
now if you specify both and add a FIXME for the git-commit behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.