[Webkit-unassigned] [Bug 38388] Merge svn-apply and svn-unapply

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38388





--- Comment #2 from Zoltan Horvath <zoltan at webkit.org>  2010-04-30 09:33:01 PST ---
(In reply to comment #1)
> Another approach that can be taken in conjunction with this approach is to
> move/refactor methods defined in both files to a third location.  The third
> location can be VCSUtils.pm or a new library file in webkitperl/ named
> something like svnApplyUtils.pm.  I started doing this myself here, for
> instance:
> 
> http://trac.webkit.org/changeset/52692 

If we follow this direction the unit-testing can be more precise not by testing
the whole file(s), but subroutines directly. If the merged functions can be
used in other files I like the idea to put it into VCSUtils, if not, separated
file would be better.

> Question: are you suggesting that, in the end, svn-unapply should be invoked by
> calling svn-apply (e.g. by passing a -R/--reverse flag)?  That sounds good.  If
> so, svn-unapply could be a wrapper for svn-apply until the callers are
> modified.

Yes. I was thinking on the same.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.