[Webkit-unassigned] [Bug 38195] Bring CLIENT_BASED_GEOLOCATION more in line with non-client based: remove Geolocation::setPosition and use lastPosition()

Fri Apr 30 08:55:15 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38195

Steve Block <steveblock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54413|review?                     |review-
               Flag|                            |

--- Comment #4 from Steve Block <steveblock at google.com>  2010-04-30 08:55:15 PST ---
(From update of attachment 54413)
> - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
I think it's best to leave the whitespace changes out of this patch for
clarity.

> +    if (m_lastPosition.get())
> +        return m_lastPosition.get();
Is this caching required for correct behaviour or is it just an optimisation?
GeolocationController::lastPosition() should only be called once the client has
called GeolocationController::positionChanged(), and it seems that the client
should always have a last position available by this time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.