[Webkit-unassigned] [Bug 38391] New: makeprop and makevalues: fix build with gcc 4.5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38391

           Summary: makeprop and makevalues: fix build with gcc 4.5
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: leandro at profusion.mobi


When building with gcc 4.5, I get errors like this:

[ 10%] Building C object
WebCore/CMakeFiles/webcoreefl.dir/__/DerivedSources/CSSValueKeywords.c.o
In file included from CSSValueKeywords.gperf:4:0:
/home/leandro/svn/webkit/build/DerivedSources/CSSValueKeywords.h:631:14: error:
expected '=', ',', ';', '
asm' or '__attribute__' before 'maxCSSValueKeywordLength'
CSSValueKeywords.gperf: In function 'findValue':
CSSValueKeywords.gperf:301:7: error: initializer element is not constant
CSSValueKeywords.gperf:301:7: error: (near initialization for
'wordlist_value[0].id')
CSSValueKeywords.gperf:34:7: error: initializer element is not constant
CSSValueKeywords.gperf:34:7: error: (near initialization for
'wordlist_value[1].id')
CSSValueKeywords.gperf:318:7: error: initializer element is not constant
CSSValueKeywords.gperf:318:7: error: (near initialization for
'wordlist_value[2].id')
CSSValueKeywords.gperf:299:7: error: initializer element is not constant
(...)

The first message is because size_t isn't defined (stddef.h needs to be
included), the rest I don't really know why they happen, but changing the
declarations in CSSValueKeywords.h to an enum (just like makeprop does) fixes
the problem.

Also, the generated C files needs to include string.h because they use
strncmp().

Attached patch fixes these problems.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.