[Webkit-unassigned] [Bug 38375] Add codegen support for unsigned right shift

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 29 23:35:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38375


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-29 23:35:40 PST ---
Attachment 54785 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
exit_code: 1
JavaScriptCore/assembler/MacroAssemblerARM.h:182:  shift_amount is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/assembler/MacroAssemblerX86Common.h:253:  shift_amount is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
JavaScriptCore/assembler/X86Assembler.h:678:  shrl_i8r is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/assembler/X86Assembler.h:688:  shrl_CLr is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/assembler/MacroAssemblerARMv7.h:261:  shift_amount is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list