[Webkit-unassigned] [Bug 38363] Handle double on righthand side of a right shift

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38363


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54760|review?                     |review+
               Flag|                            |




--- Comment #3 from Gavin Barraclough <barraclough at apple.com>  2010-04-29 18:34:53 PST ---
(From update of attachment 54760)
I think the if/else cases could be a little clearer if you structured them like
this:

if (isOperandConstantImmediateInt(op2)) {
    // ...
    // ... (1 slow case to link), (optimization goes here!)
    // ...
} else if (isOperandConstantImmediateInt(op1)) {
    // ...
    // ... (1 slow case to link)
    // ...
} else { // !isOperandConstantImmediateInt(op1) &&
!isOperandConstantImmediateInt(op2)
    // ...
    // ... (2 slow cases to link), (optimization goes here!)
    // ...
}

buts that's personal taste, r+ either way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.