[Webkit-unassigned] [Bug 33287] PNGEncoder.cpp lacks support for libpng 1.4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33287


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54700|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Jeremy Orlow <jorlow at chromium.org>  2010-04-29 07:21:44 PST ---
(From update of attachment 54700)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 58506)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,17 @@
> +2010-04-29  Paweł Hajdan, Jr.  <phajdan.jr at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fix building with libpng-1.4.
> +        https://bugs.webkit.org/show_bug.cgi?id=33287
> +
> +        No new tests (no behavior change).
> +
> +        Original patch by John Bowler <jbowler at acm.org>
> +
> +        * platform/image-encoders/skia/PNGImageEncoder.cpp:
> +        (WebCore::PNGImageEncoder::encode):
> +
>  2010-04-29  Kwang Yul Seo  <skyul at company100.net>
>  
>          Reviewed by Simon Hausmann.
> Index: WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp
> ===================================================================
> --- WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp	(revision 58494)
> +++ WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp	(working copy)
> @@ -130,9 +130,7 @@ bool PNGImageEncoder::encode(const unsig
>      }
>  
>      png_struct* pngPtr = png_create_write_struct(PNG_LIBPNG_VER_STRING,
> -                                                 png_voidp_NULL,
> -                                                 png_error_ptr_NULL,
> -                                                 png_error_ptr_NULL);
> +                                                 0, 0, 0);

Sorry I wasn't clear, but the line needs to look like this: "png_struct* pngPtr
= png_create_write_struct(PNG_LIBPNG_VER_STRING, 0, 0, 0);"

The original line was not in WebKit style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.